Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc gallery and paper figure example #36

Merged
merged 11 commits into from
Jan 23, 2025

Conversation

samaloney
Copy link
Member

@samaloney samaloney commented Aug 19, 2024

  • Figure out fits for Fig 6
  • Add earlier Figures

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.61%. Comparing base (07772ed) to head (b0e1fad).
Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #36       +/-   ##
===========================================
+ Coverage   11.90%   97.61%   +85.71%     
===========================================
  Files           1        1               
  Lines         252      252               
===========================================
+ Hits           30      246      +216     
+ Misses        222        6      -216     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samaloney
Copy link
Member Author

samaloney commented Aug 19, 2024

Never mind it was the order of the interpolation.

So the test fail is due to deprecation of interp2d but it seems the replacement RectBivarateSpline doesn't give identical results for this case 🤯

from scipy.interpolate import RectBivariateSpline


data = fits.getdata(im171[0], ext=0) / (heda["EXPTIME"])
dn = scipy.interpolate.interp2d(x, x, data)
data_old = scipy.interpolate.interp2d(x, x, data)
rbs = RectBivariateSpline(x, x, data)
data_new = rbs(np.arange(0, 4096), np.arange(0, 4096))

(data_old - data_new).min()
# -866.2201822671041
(data_old - data_new).max()
# 394.46359265847195

plt.imshow(data_old - data_new)

image

@samaloney samaloney force-pushed the docs-example-gallery branch from 0a4a7c3 to f0df63c Compare September 4, 2024 15:49
@samaloney samaloney merged commit 71fa218 into TCDSolar:main Jan 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant