Turning on formatting, add real test and small code refactor #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaloney
force-pushed
the
feat-formating-test
branch
from
8773463 to
2d90718
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage ? 97.61%
=======================================
Files ? 1
Lines ? 252
Branches ? 0
=======================================
Hits ? 246
Misses ? 6
Partials ? 0 ☔ View full report in Codecov by Sentry. |
samaloney
commented
Jun 13, 2024
| @@ -158,7 +151,7 @@ def chimera_legacy(): | |||
| "num", | |||
| '"', | |||
| '"', | |||
| "H°", | |||
There was a problem hiding this comment.
These were causing funny issues on windows I can only guess some UTF encoding problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.