-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
@@ -20,6 +20,340 @@ import ( | |||
"gopkg.in/h2non/gock.v1" | |||
) | |||
|
|||
const w3cCredentialContext = `{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be loaded from a file instead? I thought we had context caching somewhere else...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't aware. I found https://github.com/TBD54566975/ssi-sdk/pull/102/files , but we need to do some more piping in order to have the cache be pre-loaded. Right now, the processor caches documents, but it still needs to fetch them once from the network.
Ok if I take on a follow up? Requires changes in SDK and the service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
certainly, in the meantime can you move this to a file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracking in #619
Codecov Report
@@ Coverage Diff @@
## main #613 +/- ##
=======================================
Coverage 27.03% 27.03%
=======================================
Files 48 48
Lines 5830 5830
=======================================
Hits 1576 1576
Misses 3971 3971
Partials 283 283 |
Overview
Fixes #612 by using the verifier that only has the public key.
Description
This was a simple oversight, as
NewDataIntegrityKeyAccess
does not accept a public key as the third parameter.How Has This Been Tested?
Added a test the failed before, and passes after. The mock crazyness is all so that json-ld works without having to retrieve things from the network.