Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Use the correct verifier for DI VCs #613

Merged
merged 3 commits into from
Jul 31, 2023

Conversation

andresuribe87
Copy link
Contributor

Overview

Fixes #612 by using the verifier that only has the public key.

Description

This was a simple oversight, as NewDataIntegrityKeyAccess does not accept a public key as the third parameter.

How Has This Been Tested?

Added a test the failed before, and passes after. The mock crazyness is all so that json-ld works without having to retrieve things from the network.

@@ -20,6 +20,340 @@ import (
"gopkg.in/h2non/gock.v1"
)

const w3cCredentialContext = `{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be loaded from a file instead? I thought we had context caching somewhere else...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware. I found https://github.com/TBD54566975/ssi-sdk/pull/102/files , but we need to do some more piping in order to have the cache be pre-loaded. Right now, the processor caches documents, but it still needs to fetch them once from the network.

Ok if I take on a follow up? Requires changes in SDK and the service.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

certainly, in the meantime can you move this to a file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking in #619

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Merging #613 (1a98331) into main (b43f45c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #613   +/-   ##
=======================================
  Coverage   27.03%   27.03%           
=======================================
  Files          48       48           
  Lines        5830     5830           
=======================================
  Hits         1576     1576           
  Misses       3971     3971           
  Partials      283      283           

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Verification of valid DID Configuration fails
3 participants