Skip to content

Commit

Permalink
feat: tup-463 migrate css to core (#344)
Browse files Browse the repository at this point in the history
* docs: more css thoughts in comment

* docs: more css thoughts in comment

* feat: tup-619 c-content block migration (#346)

* feat: tup-619 c-content block migration

* removed content-block import

* feat: tup-623 c-update migration (#348)

* migrated c-update to core-styles

* removed c-update import

* feat: tup-624: added generics/attributes to demo (#345)

* feat: tup-624: added generics/attributes to demo

* migrated rest of attributes.css to core-styles

* removed unnecessary comments in css file for c-button

* feat/tup-625: Migrate o-heading-steps to core-styles (#349)

* feat/tup-630: Migrate django.cms.blog.app.item (#351)

* getting rid of django.cms.blog.app.item.css

* removing the import for django.cms.blog.app.item.css

* feat/tup-632: Migrate django.cms.picture.css to core-cms (#355)

* Migrate c-card fixes to core-styles (#361)

Co-authored-by: Wesley Bomar <[email protected]>

* Migrated header to Core-Styles (#359)

Co-authored-by: Wesley Bomar <[email protected]>

* fix: tup-617 c-button font-weight redunant style (#364)

* feat(tup-cms): core-cms with core-styles v2.19

* chore: lowercase comment

* feat(tup-cms)!: core-cms with core-styles v2.19

WARNING: v2.17.3 causes login form field bug.

* feat/tup-634: Migrate pseudo-elements to core-cms (#358)

* feat/tup-625: delete u-highlight stylesheet (#352)

No need for u-highlight per jira ticket

Co-authored-by: Wesley B <[email protected]>

* Migrate card list support to core-styles (#360)

Co-authored-by: Wesley Bomar <[email protected]>

* feat/tup-626: delete o-section from tup-ui (#353)

* I believe this has already been merged into core-styles... Padding and Margin seem to be available on prod

* remove import of core-styles o-heading-steps.css

* feat/tup-633: Migrate lightgallery to core-cms (#357)

* feat/tup-633: Migrate lightgallery to core-cms

* delete unnecessary import of django.cms.picture.css

* feat/tup-629: delete footer (#356)

* feat/tup-629: delete footer

Footer is already in core-styles and cms

* remove unnecessary imports

* removing all card--image styles (#365)

* chore: tup-616 migrate c-button styles to core-cms (#343)

* chore: migrate c-button styles to core-cms

TACC/Core-CMS#729

* fix: remove import of file deleted in merge

---------

Co-authored-by: Tomas Gonzalez <[email protected]>

* feat/tup-622 migrate c-pill to core-styles (#367)

* feat/tup-640 Delete c-card and c-content-block imports (#368)

* feat(tup-cms): core-cms with core-styles v2.20

WARNING: Introduces login form field width bug. (Core-Styles v2.17.3 might be the cause.)

* feat(tup-ui): core-styles v2.20

* feat(tup-cms): core-styles v2.21 + via core-cms

* feat: tup 648 do not use plain highlight class (#370)

* feat: tup-648 do not use plain highlight class

* feat: tup-648 do not use plain highlight class

* bug/tup-650: Resetting (unset) padding-block from cms (#371)

* bug/tup-650: Remove padding-block from cms

* adjusted comments to relative code blocks

* fix: tup-654 use c-form--login from core-styles (#374)

* fix: tup-654 use c-form--login from core-styles

* chore: tup-654 remove redundant `c-form` classname

* chore: tup-463 remove temp. core-styles imports (#375)

Some Core-Styles were loaded via CDN, cuz CMS did not have latest yet.

Now CMS has much more recent Core-Styles, so use them. Do not duplicate.

* enhance: tup-463 login component should use core-styles (#376)

* chore: tup-463 remove temp. core-styles imports

Some Core-Styles were loaded via CDN, cuz CMS did not have latest yet.

Now CMS has much more recent Core-Styles, so use them. Do not duplicate.

* chore: tup-463 delete css modules mimicking core

Some Core-Styles CSS was added after TUP login form was developed.

Now that it is available, TUP lofin form can use it. Less module CSS!

* style: npx nx format:write

* chore: tup-463 delete css modules mimicking core (#377)

Some Core-Styles CSS was added after TUP login page was developed.

Now that it is available, TUP login page can use it. Less module CSS!

* feat: core-styles v2.21.0 to v2.21.1

* feat: core-cms, core-styles v2.21.0 to v2.21.1

* hotfix: tup-654 mfa c nav pipe not showing (#379)

* hotfix: tup-654 mfa's c-nav not showing a pipe

1. There should be a pipe (border) between nav links.
2. The `c-button--as-link` nav link's pipe was present but invisible.
3. c-button x-truncate `overflow: hidden` overwrote `overflow: visible`.
4. It should be the other way around.
5. Composing c-button from dist/ includes entire file into global scope.
6. Isntead, compose from src, to get only what is necessary.

* hotfix: tup-654 mfa's c-nav not showing a pipe

1. There should be a pipe (border) between nav links.
2. The `c-button--as-link` nav link's pipe was present but invisible.
3. c-button x-truncate `overflow: hidden` overwrote `overflow: visible`.
4. It should be the other way around.
5. Importing c-form--login without layer gave it precedence.
6. Instead, import into base layer, so all Core-Styles are in base.

* chore: remove redundant import of cortal.icon.css (#380)

The core-styles.portal.css already includes cortal.icon.css.

* hotfix: tup-658 login form title too small (#381)

* hotfix: tup-658 form login title too small

* docs: idea, Core-Styles elements/headings--portal

* feat: core-cms, core-styles v2.21.1 to v2.21.2

* feat: core-cms, core-styles v2.21 to v2.22

* feat: core-cms w/ core-styles' django-cms-forms

TACC/Core-CMS#678 since 0335d90.

* fix: core-cms core-styles' django-cms-forms

TACC/Core-CMS#678 (latest as of now)

* feat: tup-463 migrate css to core - misc bugs (#384)

* chore: search dropdown should use var for white

* fix: footer buttons should not have width limit

* refactor: deprecate `<small>` in footer buttons

* fix!: do not let search styles bleed beyond search

Requires an `id="tacc-google-search` wrapper.

* fix: remove unnecessary style

The only `<h1>` on the page is "Search" text provided by CMS not Google.

* docs: explain strange, complex search css selector

* fix: core-styles v2.22.0 to v2.22.1

* chore: core-styles v2.22.1 to v2.22.2

* chore: core-cms v4.2.0

---------

Co-authored-by: Tomas Gonzalez <[email protected]>
Co-authored-by: Tomas Gonzalez <[email protected]>
  • Loading branch information
3 people authored Nov 30, 2023
1 parent bf9944a commit eb3f7f0
Show file tree
Hide file tree
Showing 34 changed files with 87 additions and 662 deletions.
4 changes: 2 additions & 2 deletions apps/tup-cms/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# TACC/Core-CMS#735 (cms-forms export hotfix)
FROM taccwma/core-cms:5ceecdd
# TACC/Core-CMS#v4.2.0
FROM taccwma/core-cms:5d26e2b

WORKDIR /code

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
left: 0; top: 0; bottom: 0; right: 0;
background-color: var(--global-color-primary--x-light);
}
.banner-cell--major a:hover .highlight {
.banner-cell--major a:hover .u-highlight {
background-color: var(--global-color-accent--normal);
}

Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/* Media & Content - Alignment */
/* TODO: Share relevant styles with c-news and c-feed-list */



Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
#cms-content {
#tacc-google-search {
/* Whole Search Container */
/* removes padding from search container */
& .gsc-control-cse {
padding: unset;
}

/* make header same as news */
& h1 {
color: var(--global-color-primary--x-dark);
}




Expand All @@ -27,15 +22,16 @@
border-bottom: unset;
}

& tbody>tr:first-child>:is(td, th) {
/* To override Core-Styles tables */
& tbody > tr:first-child > :is(td, th) {
border: unset;
padding-inline: unset;
background: unset;
vertical-align: middle;
}

& .gsc-selected-option-container {
background: #fff;
background: var(--global-color-primary--xx-light);
border: var(--global-border--normal);
}

Expand Down Expand Up @@ -134,4 +130,4 @@
vertical-align: unset;
top: 1px;
}
}
}

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit eb3f7f0

Please sign in to comment.