Skip to content

Commit

Permalink
chore(tup-ui): resolve some files with github check annotations (#204)
Browse files Browse the repository at this point in the history
* chore: resolve some files with check annotations

This is an attempt to quiet Github PR "Unchanged files with check annotations Beta".

* chore: nx format:write

---------

Co-authored-by: Jake Rosenberg <[email protected]>
  • Loading branch information
wesleyboar and jarosenb authored May 1, 2023
1 parent 60277bf commit df9eb6f
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 24 deletions.
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
import { FormikInput } from '@tacc/core-wrappers';
import * as Yup from 'yup';
import {
UIWizardStep,
useWizardValues,
UIWizardSchema,
InitialValueGenerator,
} from '..';
import { UIWizardStep, useWizardValues, InitialValueGenerator } from '..';

export const StepOne: React.FC = () => {
const { extra } = useWizardValues();
Expand Down
14 changes: 6 additions & 8 deletions libs/core-components/src/lib/Form/FormField.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,12 @@ const FormField = ({
</Label>
);
const FieldNote = () => (
<>
<FormText className="form-field__help" color="muted">
{description}
{meta.touched && meta.error && (
<div className="form-field__validation-error">{meta.error}</div>
)}
</FormText>
</>
<FormText className="form-field__help" color="muted">
{description}
{meta.touched && meta.error && (
<div className="form-field__validation-error">{meta.error}</div>
)}
</FormText>
);

// Allowing ineffectual prop combinations would lead to confusion
Expand Down
2 changes: 1 addition & 1 deletion libs/core-components/src/lib/Icon/Icon.test.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import Icon from './Icon';

const NAME = 'test-icon-name';
const CLASS = 'test-class-name';
const TEXT = 'test-icon-text';
// const TEXT = 'test-icon-text';
const LABEL = 'test-icon-label';

describe('Icon', () => {
Expand Down
2 changes: 1 addition & 1 deletion libs/core-wrappers/src/lib/Navbar/Navbar.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { NavLink, useSearchParams } from 'react-router-dom';
import { NavLink } from 'react-router-dom';
import { Icon } from '@tacc/core-components';
import styles from './Navbar.module.css';

Expand Down
6 changes: 3 additions & 3 deletions libs/tup-components/src/layout/Sidebar/Sidebar.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import React from 'react';
import { Navbar, NavItem, AnchorNavItem } from '@tacc/core-wrappers';
import { useAuth } from '@tacc/tup-hooks';
import { Navbar, NavItem } from '@tacc/core-wrappers';
// import { useAuth } from '@tacc/tup-hooks';
import styles from './Sidebar.module.css';

const Sidebar: React.FC = () => {
const { loggedIn } = useAuth();
// const { loggedIn } = useAuth();
return (
<div className={styles['root']}>
<Navbar>
Expand Down
5 changes: 0 additions & 5 deletions libs/tup-components/src/projects/details/ProjectDetails.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,6 @@ import {
import { ProjectsListingAllocationTable } from '../ProjectsListing/ProjectsListingAllocationTable';
import ProjectPublicationRemove from './publications/ProjectPublicationDelete';

const formatDate = (datestring: string): string => {
const date = new Date(datestring);
return `${date.getMonth() + 1}/${date.getDate()}/${date.getFullYear()}`;
};

const Publication: React.FC<{
projectId: number;
pub: ProjectPublication;
Expand Down

0 comments on commit df9eb6f

Please sign in to comment.