PR Submission Guidelines

PR Submissions

When creating a new PR, the PR template will include a few pre-populated fields. Make sure to update things like the Jira task id, add relevant photos, and assign 2 reviewers.

After submission

When submitting a PR, make a post in the #frontera-portal-prgrmrs Slack channel to notify the team that the PR is up, and initiate a discussion thread on the post, tagging the reviewers on Slack.

e.g.

New PR: FP-1234 Backend Enhancements

In thread:

@stijerina @Nathan Franklin

As a reviewer, when you have completed a review, tag the PR Author on Slack, for example in the thread mentioned above. As an author, when you have addressed comments, tag the reviewers again on Slack.