Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/WP-729: Mutation hook: Move files #996

Merged
merged 22 commits into from
Dec 6, 2024
Merged

Task/WP-729: Mutation hook: Move files #996

merged 22 commits into from
Dec 6, 2024

Conversation

jmcmillenmusic
Copy link
Collaborator

Overview

We are working on updating our current mutations to utilize TypeScript and React Query instead of React Redux. This should improve the speed and functionality of all portal systems going forward.

Related

Changes

I converted useMove.js to useMove.ts and created a mutation that moves one or more files to a new location by updating its path.

Testing

  1. Navigate to a file that you want to move.
  2. Select it and click on Move.
  3. Select the folder that you want to move the selected file into and click on Move.
  4. You should get a notification stating that the file is moved to its new location.

UI

image

Notes

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 20.72072% with 88 lines in your changes missing coverage. Please review.

Project coverage is 72.68%. Comparing base (f5c373f) to head (9b791bb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
client/src/hooks/datafiles/mutations/useMove.ts 20.72% 88 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #996      +/-   ##
==========================================
- Coverage   72.85%   72.68%   -0.17%     
==========================================
  Files         534      534              
  Lines       33581    33657      +76     
  Branches     2988     2989       +1     
==========================================
  Hits        24464    24464              
- Misses       8919     8995      +76     
  Partials      198      198              
Flag Coverage Δ
javascript 75.40% <20.72%> (-0.21%) ⬇️
unittests 60.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
client/src/hooks/datafiles/mutations/useMove.ts 20.72% <20.72%> (ø)

@jmcmillenmusic jmcmillenmusic changed the title Task/wp 729 Task/WP-729: Mutation hook: Move files Nov 5, 2024
Copy link
Member

@rstijerina rstijerina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on these! As a part of this task, should sagas be removed as well? Thoughts @jarosenb ?

client/src/hooks/datafiles/mutations/useMove.ts Outdated Show resolved Hide resolved
client/src/hooks/datafiles/mutations/useMove.ts Outdated Show resolved Hide resolved
client/src/hooks/datafiles/mutations/useMove.ts Outdated Show resolved Hide resolved
Copy link
Member

@rstijerina rstijerina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just one comment

client/src/hooks/datafiles/mutations/useMove.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@jalowe13 jalowe13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I also agree to the suggestion to remove the console log mentioned in #996 (comment) by @rstijerina
Works as intended on my end!

@chandra-tacc chandra-tacc merged commit 498d801 into main Dec 6, 2024
4 of 6 checks passed
@chandra-tacc chandra-tacc deleted the task/WP-729 branch December 6, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants