-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/WP-731: Mutation hook: Trash file/folder #994
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #994 +/- ##
==========================================
- Coverage 72.68% 72.58% -0.11%
==========================================
Files 534 534
Lines 33656 33733 +77
Branches 2989 2993 +4
==========================================
+ Hits 24464 24484 +20
- Misses 8994 9051 +57
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does delete! Just a couple of changes for ensuring axios instead of the generic fetch request. And changes on making sure we are ensuring all promises of all deletion operations are met! Looks great so far
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the typing change up top its almost good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Overview
We are working on updating our current mutations to utilize TypeScript and React Query instead of React Redux. This should improve the speed and functionality of all portal systems going forward.
Related
Changes
I converted
useTrash.js
touseTrash.ts
and created a mutation that sends a selected file/folder to the Trash by updating its path.Testing
UI
Notes