Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/WP-356: Use home dir to isolate the search. #897

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

chandra-tacc
Copy link
Collaborator

@chandra-tacc chandra-tacc commented Nov 6, 2023

Overview

Site search is resulting in public and community files from root level path.

Related

Changes

Use the home directory for public and community data files as path to search.

Testing

Deployed the branch to dev.cep

  • Used site search and checked the following:
    • The paths listed in the public and community data folders are accurate. They are correctly based on config: corral/tacc/aci/CEP/public and corral/tacc/aci/CEP/community
    • The search results from site-search match the results from data files search.

Screenshots:

Site search shows 37 results for public and 6 results for community:
Screenshot 2023-11-07 at 12 25 42 PM

Public file search shows 37 results:
Screenshot 2023-11-07 at 12 32 21 PM

Community file search shows 6 results
Screenshot 2023-11-07 at 12 32 42 PM

UI

NA

Notes

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #897 (8cb62c6) into main (7c0ba55) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #897   +/-   ##
=======================================
  Coverage   63.41%   63.41%           
=======================================
  Files         432      432           
  Lines       12389    12389           
  Branches     2579     2579           
=======================================
  Hits         7856     7856           
  Misses       4323     4323           
  Partials      210      210           
Flag Coverage Δ
javascript 69.76% <ø> (ø)
unittests 56.94% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
server/portal/apps/site_search/api/views.py 86.36% <100.00%> (ø)

@chandra-tacc chandra-tacc force-pushed the bug/WP-356-site-search branch from b125b29 to 634ffbb Compare November 7, 2023 03:43
@chandra-tacc chandra-tacc marked this pull request as ready for review November 7, 2023 19:07
Copy link
Contributor

@shayanaijaz shayanaijaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chandra-tacc chandra-tacc merged commit e935225 into main Nov 7, 2023
6 checks passed
@chandra-tacc chandra-tacc deleted the bug/WP-356-site-search branch November 7, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants