bug/WP-319: Fix email confirmation for tickets #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #879 +/- ##
=======================================
Coverage 63.44% 63.44%
=======================================
Files 427 427
Lines 12215 12215
Branches 2510 2510
=======================================
Hits 7750 7750
Misses 4259 4259
Partials 206 206
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
good find. I tested it and I got email confirmation. |
rstijerina
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The rtpy documentation is misleading: https://python-rt.readthedocs.io/en/latest/rest1.html#rt.rest1.Rt.create_ticket
Specifying "Requestors" instead of "Requestor" as we've been doing causes the requestors to be added AFTER ticket creation, meaning no one gets an email confirmation.
Related
Changes
Requestorinstead ofRequestorsto the create_ticket util.Testing