Task/WP-66: Refactored some variables and props to include proptypes #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asimregmi
requested review from
shayanaijaz
and removed request for
shayanaijaz
Codecov Report
@@ Coverage Diff @@
## main #876 +/- ##
==========================================
- Coverage 63.00% 62.99% -0.02%
==========================================
Files 427 427
Lines 12191 12197 +6
Branches 2504 2506 +2
==========================================
+ Hits 7681 7683 +2
- Misses 4303 4306 +3
- Partials 207 208 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
asimregmi
changed the title
chandra-tacc
approved these changes
Oct 9, 2023
| @@ -286,6 +286,7 @@ const DataFilesProjectMembers = ({ | |||
| }; | |||
|
|
|||
| DataFilesProjectMembers.propTypes = { | |||
| projectId: PropTypes.string, | |||
There was a problem hiding this comment.
Without projectId, was this broken previously. This seems more than refactor?
There was a problem hiding this comment.
Wasn't broken but included it for typechecking. I can remove it if its out of scope for this PR.
chandra-tacc
pushed a commit
that referenced
this pull request
Oct 9, 2023
…876) * Refactored some variables and props to include proptypes * fixed linting errors
chandra-tacc
added a commit
that referenced
this pull request
Oct 10, 2023
* WA-314: Input file fixes for hidden and fixed * Task/WP-66: Refactored some variables and props to include proptypes (#876) * Refactored some variables and props to include proptypes * fixed linting errors * WP-299: Add Data Files button dropdown needs minor adjustment in alignment (#878) * small UI change to align dropdown * linting issues fixed --------- Co-authored-by: Chandra Y <[email protected]> --------- Co-authored-by: Asim Regmi <[email protected]>
chandra-tacc
added a commit
that referenced
this pull request
Oct 10, 2023
* WA-314: Input file fixes for hidden and fixed * Task/WP-66: Refactored some variables and props to include proptypes (#876) * Refactored some variables and props to include proptypes * fixed linting errors * WP-299: Add Data Files button dropdown needs minor adjustment in alignment (#878) * small UI change to align dropdown * linting issues fixed --------- Co-authored-by: Chandra Y <[email protected]> --------- Co-authored-by: Asim Regmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some variable names and props in the DataFiles components weren't descriptive enough. This change fixes that to the extent without changing the original intention of the code. Also some of the variables needed destructuring which this achieves.
Related
Changes
Testing
UI
No visible UI change expected from this PR
Notes