Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/WP-297: Fix site search for public and community data #870

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

rstijerina
Copy link
Member

Overview

Public and community data system site search currently fails, due to a missing client for a files listing safety check.

Related

Testing

  1. Search in the site search and confirm it does not fail, both logged in and logged out

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #870 (1799748) into main (78bb6e0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #870   +/-   ##
=======================================
  Coverage   62.99%   63.00%           
=======================================
  Files         427      427           
  Lines       12188    12191    +3     
  Branches     2504     2504           
=======================================
+ Hits         7678     7681    +3     
  Misses       4303     4303           
  Partials      207      207           
Flag Coverage Δ
javascript 68.71% <ø> (ø)
unittests 57.29% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
server/portal/apps/site_search/api/views.py 86.36% <100.00%> (+0.99%) ⬆️
server/portal/libs/agave/operations.py 65.00% <ø> (ø)

Copy link
Collaborator

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for quick fix.

Copy link
Collaborator

@jarosenb jarosenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rstijerina rstijerina merged commit 3c7ebf1 into main Oct 3, 2023
@rstijerina rstijerina deleted the bug/WP-298--fix-site-search branch October 3, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants