Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick: handle missing default system; enable work as default system locally #867

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

rstijerina
Copy link
Member

Overview

  • Fixes case where the default system is not the first system in the list
  • Fixes case where no default is set, and sets first system as default if so
  • Adds the scratch filesystem, and removes the my data corral filesystem
  • Sets the work filesystem as default locally

Testing

  1. Spin up the portal and confirm the work filesystem is default
  2. Confirm the scratch filesystem also works
  3. Remove the default flag from the work filesystem in _PORTAL_DATAFILES_STORAGE_SYSTEMS and confirm work is still set as default
    1. Remove the default flag from the work filesystem in _PORTAL_DATAFILES_STORAGE_SYSTEMS and make another filesystem default, and confirm that system now shows as default

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #867 (8dadfcb) into main (66d4f6d) will increase coverage by 0.06%.
The diff coverage is 66.66%.

❗ Current head 8dadfcb differs from pull request most recent head 91b5a54. Consider uploading reports for the commit 91b5a54 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
+ Coverage   62.99%   63.05%   +0.06%     
==========================================
  Files         427      427              
  Lines       12188    12144      -44     
  Branches     2504     2492      -12     
==========================================
- Hits         7678     7658      -20     
+ Misses       4303     4281      -22     
+ Partials      207      205       -2     
Flag Coverage Δ
javascript 68.88% <100.00%> (+0.16%) ⬆️
unittests 57.27% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...nt/src/components/Applications/AppForm/AppForm.jsx 69.48% <100.00%> (+4.70%) ⬆️
server/portal/apps/datafiles/views.py 67.41% <100.00%> (ø)
server/portal/settings/settings_default.py 0.00% <ø> (ø)
server/portal/settings/settings.py 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Collaborator

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@shayanaijaz shayanaijaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rstijerina rstijerina merged commit 033f8a6 into main Sep 29, 2023
4 checks passed
@rstijerina rstijerina deleted the fix/default-system-settings branch September 29, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants