bug/WP-249 Shared Workspace Copy Bug Fix #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #858 +/- ##
==========================================
- Coverage 63.08% 63.07% -0.01%
==========================================
Files 427 427
Lines 12148 12150 +2
Branches 2490 2492 +2
==========================================
+ Hits 7663 7664 +1
- Misses 4280 4281 +1
Partials 205 205
Flags with carried forward coverage won't be shown. Click here to find out more.
|
shayanaijaz
requested review from
chandra-tacc,
nathanfranklin,
rstijerina and
van-go
chandra-tacc
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The goal for this was to fix a bug where no backend requests were sent when doing a file copy operation from a private system to a shared workspace.
Upon further investigation this bug seems to stem from a previous PR bug/FP-1567. In that PR a side effect was added that cleared the data file selection whenever a shared workspace listing happened to fix a toolbar bug that was occurring. Due to this, when a file is selected for copy and the user selects a shared workspace to copy it to, the
getProjectsListingsaga clears the selected file in the state, and since there is no file to copy anymore no backend request was made when the copy button is clicked.Related
Changes
modalparam to the payload inDataFilesProjectsListsaga that indicates whether or not a modal is activegetProjectsListingsaga where theDATA_FILES_CLEAR_FILE_SELECTIONside effect isn't run when a modal is activeTesting
UI
No UI changes
Notes