WP-190: Client Token Mutex #856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #856 +/- ##
==========================================
- Coverage 63.05% 63.03% -0.02%
==========================================
Files 427 427
Lines 12131 12136 +5
Branches 2481 2482 +1
==========================================
+ Hits 7649 7650 +1
- Misses 4278 4282 +4
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chandra-tacc
requested changes
Sep 8, 2023
| @@ -81,7 +82,11 @@ def client(self): | |||
| with transaction.atomic(): | |||
| if self.expired: | |||
| try: | |||
| client.refresh_tokens() | |||
| lock = Lock() | |||
There was a problem hiding this comment.
creating a lock object within this client function will not achieve mutual exclusion. A new lock object is created always and two threads are not looking at same lock anymore.
The lock = Lock() needs to be created at class level.
|
Closing in favor of #882 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Attempting to add a threading lock to the client refresh token code so that it doesn't keep trying to refresh the token on new threads.
Related
Changes
Added a small bit of code to (hopefully) lock the refresh_token function so that it is only called once.
Testing
I have no idea how to test this, definitely need to do some stress testing in dev or something before full deploy.
UI
Notes