task/WP-163 Compress Archive Path Fix

[shayanaijaz]

Overview

The goal for this task was to ensure that Download Folder actions in a public system archived the compressed file to the users default private system instead of the public system itself. If no default private system was present then the user will be presented with an error message

Related

• WP-163

Changes

1- Added a check to determine if the source system is public or private. Based on that, the archive path for the compressed file is set
2- Added functionality to send back a custom message to DataFilesDownloadMessageModal so that the user can be presented with the correct error message

Testing

1. Go to Public Data system in core portal
2. Select a folder and start the download process (make sure the folder is not empty otherwise job will fail)
3. Ensure job starts successfully and that the job output is in the default My Data (Corral) system
4. To test the error message, go to the file datafiles.sagas.js and change line 1077 to const systems = []
5. Repeat steps 1 & 2 but this time ensure the modal displays the error message: Folder downloads are unavailable in this portal

UI

Job detail with private output path for a public file

Error message

Notes

TODO:

• Add tests for datafiles saga to test the new functionality

[codecov]

Codecov Report

Merging #846 (03abe9f) into main (9a3bf2e) will increase coverage by 0.02%.
The diff coverage is 79.16%.

@@            Coverage Diff             @@
##             main     #846      +/-   ##
==========================================
+ Coverage   63.05%   63.08%   +0.02%     
==========================================
  Files         427      427              
  Lines       12131    12148      +17     
  Branches     2481     2490       +9     
==========================================
+ Hits         7649     7663      +14     
- Misses       4278     4280       +2     
- Partials      204      205       +1     

Flag	Coverage Δ
javascript	68.88% <79.16%> (+0.03%)	⬆️
unittests	57.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage
...ts/DataFiles/fixtures/DataFiles.systems.fixture.js	ø
client/src/redux/reducers/datafiles.reducers.js	ø
client/src/redux/sagas/datafiles.sagas.js	78.94%
.../DataFilesModals/DataFilesDownloadMessageModal.jsx	80.00%

[sophia-massie]

Tested locally - LGTM!

[chandra-tacc]

Tested, LGTM.
One comment, but optional.