Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requested changes to Add Analysis Dataset view #1050

Conversation

van-go
Copy link
Contributor

@van-go van-go commented Feb 6, 2025

Overview

Requested Changes to "Add Analysis Dataset" view

Related

Changes

  • Remove the “Description” field.

  • Replace the label “Base Sample” with “Reference Sample”.

  • Replace the label “Digital Dataset” with “Reference Digital Dataset”.

  • Add a drop-down menu pointing to existing datasets or “Other”.

    • If a user selects Other, they are provided with a free entry field to enter more information.
  • Add a field labeled “Other Information” to the bottom of the view (which should not be required).

Add a list of descriptions for each field that needs to be populated:

  • Reference Sample: “The sample that was analyzed.”
  • Reference Digital Dataset: “The DOI or URI of an existing public dataset from DPMP or another repository that is used for the analysis dataset.”

Analysis Type descriptions:

  • Machine Learning: “The dataset includes the analysis results coming from machine learning, deep learning, reinforcement learning, or any type of artificial intelligence algorithm.”

  • Simulation: “The dataset includes numerical/analytical simulation results.”

  • Experimental: “The dataset includes laboratory-based experiment results.”

  • Characterization: “The dataset includes digital characterization results.”

  • Other: “Specify the analysis type that the analysis dataset includes.”

  • Other Information: “Information that the authors find relevant to the analysis, such as the labels for segmentation, analysis details, etc.”

  • Comment from the PI:  It is not clear at all how to add images. Add a comment on the procedure, or if “Add” button could be moved to the end of this menu, that would be the best.

Testing

  1. Pull up the Add Analysis Dataset modal and verify requested changes are there.

UI

Renamed Fields with descriptions:
Screen Shot 2025-02-06 at 12 27 02 PM

Analysis Type dropdown with descriptions:
Screen Shot 2025-02-06 at 12 40 05 PM

Dropdown of Reference Digital Datasets including Other option:
Screen Shot 2025-02-06 at 12 27 13 PM

When Other option is selected:
Screen Shot 2025-02-06 at 12 27 24 PM

Notes

QUESTIONS:
(1) I'm not sure how to add the descriptions for the Analysis Types. I just added them to the label. "Geometric Analysis" is missing a description.
(2) The Reference Digital Dataset lists ALL existing datasets. Is this the intention? Or should they just be datasets belonging to the user?
(3) I don't know what this last comment means: "Comment from the PI:  It is not clear at all how to add images. Add a comment on the procedure, or if “Add” button could be moved to the end of this menu, that would be the best."

@van-go van-go requested review from taoteg and shayanaijaz February 6, 2025 18:44
@van-go van-go closed this Feb 13, 2025
@van-go van-go deleted the task/WC-196-Add-Analysis-Dataset-view-requested-changes branch February 13, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant