Requested changes to Add Analysis Dataset view #1050
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Requested Changes to "Add Analysis Dataset" view
Related
Changes
Remove the “Description” field.
Replace the label “Base Sample” with “Reference Sample”.
Replace the label “Digital Dataset” with “Reference Digital Dataset”.
Add a drop-down menu pointing to existing datasets or “Other”.
Add a field labeled “Other Information” to the bottom of the view (which should not be required).
Add a list of descriptions for each field that needs to be populated:
Analysis Type descriptions:
Machine Learning: “The dataset includes the analysis results coming from machine learning, deep learning, reinforcement learning, or any type of artificial intelligence algorithm.”
Simulation: “The dataset includes numerical/analytical simulation results.”
Experimental: “The dataset includes laboratory-based experiment results.”
Characterization: “The dataset includes digital characterization results.”
Other: “Specify the analysis type that the analysis dataset includes.”
Other Information: “Information that the authors find relevant to the analysis, such as the labels for segmentation, analysis details, etc.”
Comment from the PI: It is not clear at all how to add images. Add a comment on the procedure, or if “Add” button could be moved to the end of this menu, that would be the best.
Testing
UI
Renamed Fields with descriptions:
Analysis Type dropdown with descriptions:
Dropdown of Reference Digital Datasets including Other option:
When Other option is selected:
Notes
QUESTIONS:
(1) I'm not sure how to add the descriptions for the Analysis Types. I just added them to the label. "Geometric Analysis" is missing a description.
(2) The Reference Digital Dataset lists ALL existing datasets. Is this the intention? Or should they just be datasets belonging to the user?
(3) I don't know what this last comment means: "Comment from the PI: It is not clear at all how to add images. Add a comment on the procedure, or if “Add” button could be moved to the end of this menu, that would be the best."