-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task/WI-212:Fix security suggestions #1030
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1030 +/- ##
=======================================
Coverage 72.53% 72.53%
=======================================
Files 534 534
Lines 33758 33758
Branches 2993 2993
=======================================
Hits 24486 24486
Misses 9074 9074
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated Confluence: Shared UI - Bootstrap to reflect these version updates coming for Core-Portal and Core-CMS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Bootstrap v4.6.2 is coupled to jQuery v3.5 and is coupled to Popper v1.16.
I'm pretty sure I made those updates, too. Did I miss one somewhere? |
You did. Nope. All good. I was just noting your success matching versions as I read through the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found no warning signs in the Bootstrap changelog. I agree testing is just poking around the app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested, no 4xx or 5xx status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Overview
Addressing issues mentioned in UT security scan attached to JIRA. The main issues are updating Bootstrap and jQuery.
Related
Changes
Updated bootstrap from 3.3.4 to 4.6.2 and jQuery from 1.11.1 to 3.5.1
Testing
UI
Notes