Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick: CSS regression fixes- testing session 2024-11-26 #1018

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

jarosenb
Copy link
Collaborator

@jarosenb jarosenb commented Nov 26, 2024

Overview

  • Fix display of border on data files "Add" dropdown
  • Fix button group in Manage Project modal

Related

WP-783

UI

Before:
image
After:
image

Before:
image
After:
image

Notes

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.88%. Comparing base (d6d9f37) to head (18131da).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1018   +/-   ##
=======================================
  Coverage   72.88%   72.88%           
=======================================
  Files         534      534           
  Lines       33455    33455           
  Branches     2981     2981           
=======================================
  Hits        24385    24385           
  Misses       8875     8875           
  Partials      195      195           
Flag Coverage Δ
javascript 75.76% <ø> (ø)
unittests 60.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one of the fixes can be done with less code. I'll test other browsers.

Copy link
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The simplification I proposed of can be done separately. The fix itself is a restoration of some old code.

@chandra-tacc chandra-tacc merged commit b9115f5 into main Dec 3, 2024
6 checks passed
@chandra-tacc chandra-tacc deleted the quick/112624-testing-css branch December 3, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants