Bug/WP-364: Ticket creation emails are not sent to 'cc' emails #1017
Conversation
jmcmillenmusic
requested review from
chandra-tacc,
rstijerina,
shayanaijaz and
jalowe13
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1017 +/- ##
===========================================
+ Coverage 60.44% 75.76% +15.31%
===========================================
Files 211 323 +112
Lines 6285 27171 +20886
Branches 730 2251 +1521
===========================================
+ Hits 3799 20586 +16787
- Misses 2329 6547 +4218
+ Partials 157 38 -119
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -16,10 +16,10 @@ def __init__(self): | |||
|
|
|||
| def getUserTickets(self, userEmail, status="ALL"): | |||
| if not status == "ALL": | |||
| ticket_list = self.tracker.search(Queue=rt.ALL_QUEUES, Requestors__exact=userEmail, Status__exact=status, | |||
| ticket_list = self.tracker.search(Queue=rt.ALL_QUEUES, Requestor__exact=userEmail, Status__exact=status, | |||
There was a problem hiding this comment.
Is this a confirmed needed change as well?
There was a problem hiding this comment.
Based on my conversation with Chandra, he mentioned making this change anyhow.
There was a problem hiding this comment.
Yes, but this is a different endpoint, tracker.search. Can you confirm the correct field is Requestor__exact?
There was a problem hiding this comment.
The results appear to be the same regardless of whether that line says Requestor or Requestors.
There was a problem hiding this comment.
If the results are the same, then we do not need to change, since nothing is broken. The issue from PR above is in create_ticket endpoint and not search endpoint. The parameter to create_ticket is Requestor (as seen in RT source code: ).
jmcmillenmusic
changed the title
| @@ -16,10 +16,10 @@ def __init__(self): | |||
|
|
|||
| def getUserTickets(self, userEmail, status="ALL"): | |||
| if not status == "ALL": | |||
| ticket_list = self.tracker.search(Queue=rt.ALL_QUEUES, Requestors__exact=userEmail, Status__exact=status, | |||
| ticket_list = self.tracker.search(Queue=rt.ALL_QUEUES, Requestor__exact=userEmail, Status__exact=status, | |||
There was a problem hiding this comment.
If the results are the same, then we do not need to change, since nothing is broken. The issue from PR above is in create_ticket endpoint and not search endpoint. The parameter to create_ticket is Requestor (as seen in RT source code: ).
| @@ -46,7 +46,7 @@ def post(self, request): | |||
| data = request.POST.copy() | |||
| subject = data.get('subject') | |||
| problem_description = data.get('problem_description') | |||
| cc = data.get('cc', '') | |||
| cc = data.get('cc', ['']) | |||
There was a problem hiding this comment.
should this be [''] or []? In another change in this PR, the default is []
|
Note: unit tests are failing |
Overview
There is a bug that prevents CC emails from receiving emails when a ticket is first created. CC emails actually receive emails when there are replies to a ticket, however.
Related
Changes
I edited the Ticket Modal to inform users that CC emails will only receive emails on ticket replies, not ticket creation.
Testing
No testing is required since this bug cannot be fixed locally.
UI
Notes
The change that we need to make must be done globally instead of locally. That change happens here. I'll reach out to the RT channel in Slack to see if we can make that change.