-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/WP-725: Mutation Hooks: Extract Files #1010
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
37b2b6b
Started constructing useExtract.ts
0b42c8e
Still working on useExtract.ts
0eda545
Almost finished; removing the last bugs
60a5551
useExtract.ts now working 100%
a157363
Linted client-side code
8052b59
Added an additional asynchronous call
a97e568
Created useSubmitJob.ts, set up job to run similarly to compress hook
1a0813d
Merge branch 'main' into task/WP-725
jmcmillenmusic a917b86
Linted client-side code
0db1cfa
Merge branch 'task/WP-725' of github.com:TACC/Core-Portal into task/W…
0c3619b
Added allocations to DataFiles.test.jsx
d63cda4
Skipping saga tests
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,126 @@ | ||
import { useMutation } from '@tanstack/react-query'; | ||
import { useSelector, useDispatch, shallowEqual } from 'react-redux'; | ||
import { getExtractParams } from 'utils/getExtractParams'; | ||
import { apiClient } from 'utils/apiClient'; | ||
import { fetchUtil } from 'utils/fetchUtil'; | ||
import { TTapisFile } from 'utils/types'; | ||
import { TJobBody, TJobPostResponse } from './useSubmitJob'; | ||
|
||
const getAppUtil = async function fetchAppDefinitionUtil( | ||
appId: string, | ||
appVersion: string | ||
) { | ||
const params = { appId, appVersion }; | ||
const result = await fetchUtil({ | ||
url: '/api/workspace/apps', | ||
params, | ||
}); | ||
return result.response; | ||
}; | ||
|
||
async function submitJobUtil(body: TJobBody) { | ||
const res = await apiClient.post<TJobPostResponse>( | ||
`/api/workspace/jobs`, | ||
body | ||
); | ||
return res.data.response; | ||
} | ||
|
||
function useExtract() { | ||
const dispatch = useDispatch(); | ||
const status = useSelector( | ||
(state: any) => state.files.operationStatus.extract, | ||
shallowEqual | ||
); | ||
|
||
const setStatus = (newStatus: any) => { | ||
dispatch({ | ||
type: 'DATA_FILES_SET_OPERATION_STATUS', | ||
payload: { status: newStatus, operation: 'extract' }, | ||
}); | ||
}; | ||
|
||
const extractApp = useSelector( | ||
(state: any) => state.workbench.config.extractApp | ||
); | ||
|
||
const defaultAllocation = useSelector( | ||
(state: any) => | ||
state.allocations.portal_alloc || state.allocations.active[0].projectName | ||
); | ||
|
||
const latestExtract = getAppUtil(extractApp.id, extractApp.version); | ||
Check failure on line 52 in client/src/hooks/datafiles/mutations/useExtract.ts GitHub Actions / Client_Side_Unit_Testssrc/components/DataFiles/tests/DataFiles.test.jsx > DataFiles > should render Data Files with multiple private systems
|
||
|
||
const { mutateAsync } = useMutation({ mutationFn: submitJobUtil }); | ||
|
||
const extract = ({ file }: { file: TTapisFile }) => { | ||
dispatch({ | ||
type: 'DATA_FILES_SET_OPERATION_STATUS', | ||
payload: { status: 'RUNNING', operation: 'extract' }, | ||
}); | ||
|
||
const params = getExtractParams( | ||
file, | ||
extractApp, | ||
latestExtract, | ||
defaultAllocation | ||
); | ||
|
||
return mutateAsync( | ||
{ | ||
job: params, | ||
}, | ||
{ | ||
onSuccess: (response: any) => { | ||
if (response.execSys) { | ||
dispatch({ | ||
type: 'SYSTEMS_TOGGLE_MODAL', | ||
payload: { | ||
operation: 'pushKeys', | ||
props: { | ||
system: response.execSys, | ||
}, | ||
}, | ||
}); | ||
} else if (response.status === 'PENDING') { | ||
dispatch({ | ||
type: 'DATA_FILES_SET_OPERATION_STATUS', | ||
payload: { status: { type: 'SUCCESS' }, operation: 'extract' }, | ||
}); | ||
dispatch({ | ||
type: 'ADD_TOAST', | ||
payload: { | ||
message: 'File extraction in progress', | ||
}, | ||
}); | ||
dispatch({ | ||
type: 'DATA_FILES_SET_OPERATION_STATUS', | ||
payload: { operation: 'extract', status: {} }, | ||
}); | ||
dispatch({ | ||
type: 'DATA_FILES_TOGGLE_MODAL', | ||
payload: { operation: 'extract', props: {} }, | ||
}); | ||
} | ||
}, | ||
onError: (response) => { | ||
const errorMessage = | ||
response.cause === 'compressError' | ||
? response.message | ||
: 'An error has occurred.'; | ||
dispatch({ | ||
type: 'DATA_FILES_SET_OPERATION_STATUS', | ||
payload: { | ||
status: { type: 'ERROR', message: errorMessage }, | ||
operation: 'extract', | ||
}, | ||
}); | ||
}, | ||
} | ||
); | ||
}; | ||
|
||
return { extract, status, setStatus }; | ||
} | ||
|
||
export default useExtract; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
import { | ||
TTapisSystem, | ||
TAppFileInput, | ||
TTapisJob, | ||
TJobArgSpecs, | ||
TJobKeyValuePair, | ||
} from 'utils/types'; | ||
|
||
export type TJobPostOperations = 'resubmitJob' | 'cancelJob' | 'submitJob'; | ||
|
||
export type TParameterSetSubmit = { | ||
appArgs?: TJobArgSpecs; | ||
containerArgs?: TJobArgSpecs; | ||
schedulerOptions?: TJobArgSpecs; | ||
envVariables?: TJobKeyValuePair[]; | ||
}; | ||
|
||
export type TConfigurationValues = { | ||
execSystemId?: string; | ||
execSystemLogicalQueue?: string; | ||
maxMinutes?: number; | ||
nodeCount?: number; | ||
coresPerNode?: number; | ||
allocation?: string; | ||
memoryMB?: number; | ||
}; | ||
|
||
export type TOutputValues = { | ||
name: string; | ||
archiveSystemId?: string; | ||
archiveSystemDir?: string; | ||
}; | ||
|
||
export interface TJobSubmit extends TConfigurationValues, TOutputValues { | ||
archiveOnAppError?: boolean; | ||
appId: string; | ||
fileInputs?: TAppFileInput[]; | ||
parameterSet?: TParameterSetSubmit; | ||
} | ||
|
||
export type TJobBody = { | ||
operation?: TJobPostOperations; | ||
uuid?: string; | ||
job: TJobSubmit; | ||
licenseType?: string; | ||
isInteractive?: boolean; | ||
execSystemId?: string; | ||
}; | ||
|
||
export interface IJobPostResponse extends TTapisJob { | ||
execSys?: TTapisSystem; | ||
} | ||
|
||
export type TJobPostResponse = { | ||
response: IJobPostResponse; | ||
status: number; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
import { TPortalSystem, TTapisFile } from './types'; | ||
|
||
export const getCompressParams = ( | ||
files: TTapisFile[], | ||
archiveFileName: string, | ||
compressionType: string, | ||
compressApp: { id: string; version: string }, | ||
defaultAllocation: string, | ||
defaultPrivateSystem?: TPortalSystem | ||
) => { | ||
const fileInputs = files.map((file) => ({ | ||
sourceUrl: `tapis://${file.system}/${file.path}`, | ||
})); | ||
|
||
let archivePath, archiveSystem; | ||
|
||
if (defaultPrivateSystem) { | ||
archivePath = defaultPrivateSystem.homeDir; | ||
archiveSystem = defaultPrivateSystem.system; | ||
} else { | ||
archivePath = `${files[0].path.slice(0, -files[0].name.length)}`; | ||
archiveSystem = files[0].system; | ||
} | ||
|
||
return { | ||
fileInputs: fileInputs, | ||
name: `${compressApp.id}-${compressApp.version}_${ | ||
new Date().toISOString().split('.')[0] | ||
}`, | ||
archiveSystemId: archiveSystem, | ||
archiveSystemDir: archivePath, | ||
archiveOnAppError: false, | ||
appId: compressApp.id, | ||
appVersion: compressApp.version, | ||
parameterSet: { | ||
appArgs: [ | ||
{ | ||
name: 'Archive File Name', | ||
arg: archiveFileName, | ||
}, | ||
{ | ||
name: 'Compression Type', | ||
arg: compressionType, | ||
}, | ||
], | ||
schedulerOptions: [ | ||
{ | ||
name: 'TACC Allocation', | ||
description: 'The TACC allocation associated with this job execution', | ||
include: true, | ||
arg: `-A ${defaultAllocation}`, | ||
}, | ||
], | ||
}, | ||
}; | ||
}; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's build this branch off of
task/WP-724
, to pick up the base changes thereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done and done! This PR will be closed to accommodate that.