Wc 129 dataset form redirect fix #1006
Open
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…projects (#998) * add toolbar button and modal to display the tree for DRP projects * scroll modal when it overflows the screen size
* Publication flow * Refactored code, improved request pub flow * remove incorrect return statement * added versioning support + bug fixes * front end linting * bug fixes with trash, prevent copying of trashed files * settings changes, review system only visible to reviewers * refactor to use project tree to get samples
- Added citation box and citation modal for publications - Removed Last Modified column on publication listing - Changed Created to Published Date - Added data view modal to view related project information
shayanaijaz
requested changes
Nov 20, 2024
shayanaijaz
requested changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Dataset form redirect fix -- If we edit a dataset using the Edit Data button from within a dataset then the redirect navigates the user back one directory. The user should stay in the same directory where they clicked edit from.
Related
Changes
Update the reloadPath logic: Ensure reloadPath only replaces the file name when needed and keeps the full path intact if the directory has not changed.
Update reloadPage function: Modify reloadPage to avoid stripping the last directory when constructing projectUrl.
Testing
UI
Notes