Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/WP-418: site search error when user does not have community file listing access. #1005

Merged

Conversation

jalowe13
Copy link
Collaborator

Overview

site search error when user does not have community file listing access.

Related

Changes

  • Added FILES_CLIENT_SSH_OP_ERR1 as an exception to log on SSH errors
  • Added a test to reflect FILES_CLIENT_SSH_OP_ERR1 being passed into the ssh exception handler

Testing

  1. Runthe django docker container with
    docker exec -it core_portal_django bash
  2. Navigate to portals/apps/site_search
  3. Run pytest to test these specific unit tests
  4. To run all navigate back to portals and run pytest -ra

@jalowe13 jalowe13 marked this pull request as ready for review November 11, 2024 17:33
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.85%. Comparing base (84d30e5) to head (cfb0fcd).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1005   +/-   ##
=======================================
  Coverage   72.85%   72.85%           
=======================================
  Files         534      534           
  Lines       33581    33581           
  Branches     2988     2988           
=======================================
  Hits        24464    24464           
  Misses       8919     8919           
  Partials      198      198           
Flag Coverage Δ
javascript 75.61% <ø> (ø)
unittests 60.84% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
server/portal/apps/site_search/api/views.py 88.67% <100.00%> (ø)

Copy link
Collaborator

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

Copy link
Collaborator

@jmcmillenmusic jmcmillenmusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All 13 tests passed.

@chandra-tacc chandra-tacc merged commit f5c373f into main Dec 6, 2024
6 checks passed
@chandra-tacc chandra-tacc deleted the bug/WP-418--community-file-listing-ssh-error-ignore branch December 6, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants