Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/WC-17 drp project search case #1001

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

jarosenb
Copy link
Collaborator

@jarosenb jarosenb commented Nov 6, 2024

Overview

Fix bug where upper case searches weren't being matched correctly.

Related

@jarosenb jarosenb requested a review from taoteg November 6, 2024 21:57
Copy link
Collaborator

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That pesky lower(). LGTM!

Copy link
Collaborator

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@shayanaijaz shayanaijaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shayanaijaz shayanaijaz merged commit c3dfa00 into task/digital-rocks Dec 10, 2024
0 of 4 checks passed
@shayanaijaz shayanaijaz deleted the bug/WC-17--drp-project-search-case branch December 10, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants