Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate MACD and other indicators with signalperiod = 1 #48

Open
mrjbq7 opened this issue Nov 23, 2024 · 2 comments
Open

Investigate MACD and other indicators with signalperiod = 1 #48

mrjbq7 opened this issue Nov 23, 2024 · 2 comments
Assignees

Comments

@mrjbq7
Copy link
Member

mrjbq7 commented Nov 23, 2024

See these threads:

https://sourceforge.net/p/ta-lib/bugs/84/

trufanov-nok/ta-lib-rt#12 (comment)

TA-Lib/ta-lib-python#335

@mario4tier
Copy link
Member

mario4tier commented Jan 9, 2025

@trufanov-nok Did assign to you since you have already investigated and coded a solution for this 😄 No rush, do it at your convenience and if too busy I can work on it later this year.

You should now have write access to TA-Lib Core repos. You can freely modify directly the dev branch (no PR needed) and, for now, I still take care of merging to main and triggering the official release.

Consider joining Discord for more direct conversation (either public or private). My username is Mhax: https://discord.com/invite/Erb6SwsVbH

Very glad that you are now part of the org!

@mario4tier
Copy link
Member

mario4tier commented Jan 10, 2025

(Update: Will start to work on this on January 14)

@trufanov-nok As a first step, I will implement in the coming days a new "COPY" function and a new TA_MAType_DISABLED

Algo:

  • TA_COPY_Lookback always zero. No parameters.
  • TA_COPY is a simple input->output copy.
  • TA_S_COPY can become an optimized float to double array conversion.

Reasons:

  • End-user can now explicitly specify "TA_MAType_DISABLED", which internally just do a copy.
  • Keeps in one place various optimizations (e.g. memcpy).
  • Test the water about how we will handle in the future new TA_MAType that ignores optInPeriod (e.g. VIDYA)

After this, your proposed solution remains to be done (allow optInPeriod=1). The only implementation difference would be to call TA_COPY from within the various MA (whenever optInPeriod=1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants