Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to overcome issue with signal period being 1? #53

Closed
majstorb00b opened this issue Jan 9, 2025 · 3 comments
Closed

How to overcome issue with signal period being 1? #53

majstorb00b opened this issue Jan 9, 2025 · 3 comments

Comments

@majstorb00b
Copy link

No description provided.

@majstorb00b majstorb00b changed the title How to overcome issue with signal line being 1? How to overcome issue with signal period being 1? Jan 9, 2025
@mario4tier
Copy link
Member

mario4tier commented Jan 9, 2025

Is this a duplicate of #48?

If not, then please describe a bit more about the issue you are encountering.

@majstorb00b
Copy link
Author

Thank you for the quick reply.

Here’s a snapshot of my calculations:

image

I apologize for bringing up this topic again, but I wanted to clarify a few points. This is clearly a bug, but do all of the calculations appear valid except for the last two rows in the dataset? If that’s the case, is there a recommended method to recalculate those rows?

I attempted using a manually crafted EMA function to fix the final two invalid rows because i can use the warmup period, and it yielded decent results. Do you think this is a valid approach, or is there a better way to resolve the issue?

@mario4tier
Copy link
Member

For now... there is no way around the problem, so the recommendation is to not use a period of 1 with MACD.

The solution will be handled by #48, which will likely be done at some point this year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants