Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login with no email #409

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

login with no email #409

wants to merge 6 commits into from

Conversation

anjalakaturi
Copy link
Contributor

@anjalakaturi anjalakaturi commented Apr 19, 2023

closes #408

@danielfang97
Copy link
Contributor

danielfang97 commented May 18, 2023

This is kind of working. The test is submitting an email of "bademail", which doesn't fit into the regex of a valid email. Therefore, I currently have it written as a 400 error returning "Please enter a valid e-mail address". I feel this is a better response than the one in SBH1 which is a 401 stating "Your e-mail address was not recognized."
Chris, what are your thoughts?

@cjmyers
Copy link
Contributor

cjmyers commented May 19, 2023

Agreed. The message could be better.

@cjmyers
Copy link
Contributor

cjmyers commented May 19, 2023

While I've approved, please fix the message and conflicts before merging.

@cjmyers
Copy link
Contributor

cjmyers commented May 26, 2023

@anjalakaturi Please update the test to use a valid email address which is not a valid user. In this case, the message should match SB1.

@danielfang97
Copy link
Contributor

I just tested this on my local and I got the matching content. Not sure what the issue is, but will look into it more.

@cjmyers cjmyers added this to the SBH 3.0.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/login Missing response from SBH3 when no email is given
3 participants