-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript configuration #17
Conversation
Hello, is there anything I can to to help this PR get merged? |
@Swizec could u please look into this? |
@Swizec could I assist in getting this merged? |
@Swizec You still seem to be active on GitHub, but this repository seems abandoned. Do you need help maintaining it? This is an important PR. |
What's the hold up @Swizec ? |
@Swizec is clearly a typescript hater! |
From what I understand @Swizec has already went trough the trouble of rewriting this library to TypeScript, all that's missing is to output the typings files and include them as part of the package, which this PR fixes. @jacek213 there are other important non TypeScript related PRs being ignored, like #28 which would be really nice to have. |
Maybe we just fork this bad boy? Since no one is actually maintaining this? |
I think we can open a specific issue to discuss about forking the project. What do you think? |
@ricveal do you have a fork of this. I'd also like to have typings in the package. |
@sentilesdal yes, I've forked useDimensions to add the functionality described on this PR. It's not available as independent npm package because I would prefer not to duplicate the project but due the inactivity of the repository, maybe it would be interesting to continue my fork as an independent project. What do you think, guys? |
I ended up using |
Related with #16
tsconfig.json
to export type declarations.package.json
.tsconfig.json
with more restricted rules, resolving todos.