Skip to content

Conversation

@N-Olbert
Copy link
Contributor

@N-Olbert N-Olbert commented Oct 5, 2025

Summary of the changes (Less than 80 chars)

  • Migrated to MSTest V4
  • Fixed MSTEST-analyzer warnings
  • Suppressed MSTEST004 for now, as addressing this would introduce breaking changes and requires further consideration

Addresses #219 (in this specific format)

Note:
Other possibilities include introducing a separate Snapshooter.MSTestV4 package or determining the required Assert-method and [(Data)TestMethod]-attributes via reflection to remain agnostic of a specific MSTest version. If desired, I can investigate further.

@swisslife-bot
Copy link
Contributor

swisslife-bot commented Oct 5, 2025

CLA assistant check
All committers have signed the CLA.

@N-Olbert
Copy link
Contributor Author

@nscheibe Could you maybe take a look as this prevents MSTest-users from using Snapshooter / upgrading to MSTestV4 ? 🙂

@sherlock1982
Copy link

sherlock1982 commented Dec 12, 2025

I tried this and noticed an issue with MSTestV4 and NET 10. Using Microsoft Testing Platform.
If you run from command line:

dotnet run --coverage
Overall process got stuck. I can't figure out yet on why.
dotnet run works, running from VS with and without code coverage also works

Same thing with MSTestV3 perfectly works.

@epenet
Copy link

epenet commented Dec 17, 2025

@nscheibe @SbiCA @michaelstaib is there any plan to incorporate this?

MSTest v4 was released over two months ago

@SbiCA
Copy link
Contributor

SbiCA commented Dec 18, 2025

I'm neither a MS test user nor a maintainer so I'm wondering how I end up in the list 😮
Nevertheless the changes look valid on the surface to me but I guess it's @nscheibe or @michaelstaib who should do the calls 😅

@epenet
Copy link

epenet commented Dec 18, 2025

I'm neither a MS test user nor a maintainer so I'm wondering how I end up in the list 😮

Oups - sorry! I picked up your name on another PR and apparently didn't check properly.

@glucaci glucaci merged commit 95b8a51 into SwissLife-OSS:master Dec 22, 2025
1 check passed
@epenet
Copy link

epenet commented Dec 22, 2025

@glucaci this was not included in v1.1.0?
https://github.com/SwissLife-OSS/snapshooter/releases/tag/1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants