-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 3469 dependency transition 13 #3572
Conversation
I've marked this WIP for now as I've encountered a potentially blocking issue for using typed throws with swift-dependencies. If that can't be resolved, we may want to hold off moving Github functions out of AppEnvironment so we don't carry around deprecation warnings and method overloads for a long time. |
I've opened a discussion about the issue here: pointfreeco/swift-dependencies#324 There are a couple of possible workarounds:
|
…ome deprecation warnings
Dropping the |
This is the first step to move the Github related dependencies into a
GithubClient
DependencyClient
.This step moves
fetchLicense
and also drops theclient
parameter from its function call. This trickles through to a few functions inGithub
which now haveclient
-free overloads. The outdated versions are marked with deprecation warnings. These will all go away once we've fully transition alle three Github dependency functions over toGithubClient
.