Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Reset Button layout_width to 75dp and Imagecount layout_width … #1174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PaulBerger56
Copy link

…to 125dp

Description

The Reset button was not wide enough for the text, and the text was wrapping.

Fixes #(issue)

Adjusted the width of the Reset button to 75dp.
Also adjusted the width of Imagecount to 125dp because the next Image arrow was getting cut off on smaller devices after increasing the width of the Reset Button.

Screenshots from two different virtual Devices

Pixel Fold Open

Pixel Fold Open

Pixel Fold Closed

Pixel Fold Closed

Small Android Phone

Small Phone

Type of change

Just put an x in the [] which are valid.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • [x ] ./gradlew assembleDebug assembleRelease
  • [ x] ./gradlew checkstyle

Checklist:

  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings

Copy link

codeclimate bot commented Aug 7, 2024

Code Climate has analyzed commit 09d9548 and detected 0 issues on this pull request.

View more on Code Climate.

@PaulBerger56
Copy link
Author

This pull request was a fix for the issue UI improvement #1169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant