Fix service worker fetch handler and remove duplicate listener #670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical issue in the
serviceworker.js:self.fetchevent listener to prevent multiple calls toevent.respondWith, which was causing uncaught exceptions and breaking the Service Worker.offline.htmlpage for navigation requests.Changes
const self = thiswhich was incorrectly shadowing the global.fetchlistener to handle caching/network/offline fallback properly.Please review and merge. Once deployed, the site should correctly serve the offline page and have a functioning Service Worker without errors.