-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rock Tileset, Update Rock-related Sprites, and Update Signs #2960
Conversation
There's a problem with changing the rock object type to "large" in the editor, it selects .png file instead of the .sprite file, I might try to find a solution for this, if changing this behavior requires recompiling the game I will need some help. (Edit: This is no longer an issue because the new images are the same size as the hitboxes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really love this tileset, just don't know where it could be used in the game. Also, I think the previous portable rock sprites might be better to use; I know they're called "rocks", but they really resemble building blocks, so having them be square/simple design would be more beneficial imo.
The tiles blend well with forest levels, and could also be used in world 3 as a rocky sea shore. About the rock objects, I may revert them or draw a simpler shape for their sprite if needed. |
disagree; these rock tiles could be used to make drawable rock objects of any shape/size/quirk. it looks more distinctive than the current ones |
I see World 3 benefitting from these, specifically the beach setting. World 2 already has a bunch of things going for it for v0.7 so they most likely won't appear anywhere there. Could be useful for the bonus islands, outside of story mode. For portable rocks I agree with Daniel, but I see them working if adjusted to stand out more as an interactable object. Right now they look too close to the tileset which could lead to some general confusion as they may blend in too well. |
Now that you mention it, I think it would work well in World 3. |
Ok, now the rock sprites are done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have an open PR that also adds a bunch more tiles to the game (that being #2894) so you might have to change your tile IDs here, but I'd wait with that until this one is finalized to prevent ID conflicts.
Once I know concrete how many IDs mine adds, I'll tell you more regarding which IDs are free to use without issues.
Yeah I noticed that only after defining all my IDs, I will wait for your update and then I'll redefine it |
Please don't use CRLF line endings, just WHYYYYY? (in autotiles.satc) |
Huh, this explains why the diff considered the file to be entirely replaced. Until now I had no idea that such a thing existed, like, going from one line to other line can be done in different ways? Bruh! I will try to find a way of fixing it |
In your text editor you should be able to specify if you want to use CRLF or LF. |
Okay, the CRLF it is fixed now! |
I've been thinking of leaving some free/skipped IDs for you to work with, like around 200 or 300 IDs, leaving the headers like this
But idk if this is a bad decision, considering that the ideal is always using those skipped IDs whenever they are present, and not creating more of them, I'll let you decide |
I would advise against that. However, my PR is almost done, I wanna make sure it ready by the end of the day so you can adjust yours pretty soon. Been quite busy lately so it fell to the way side a bit. |
Oh, okay then |
As #2894 has been closed, i'll start working on redefining the rock tile IDs |
I'm going to start it from the beginning, due to lots of conflicts |
I might update most of the other signs later
The icon would overlap the nails on the wall sign variant
This commit adds the sign base as tiles along wall and hanging sign base variants. It also adds all the sign icons as decals to be used with those bases.
Okay, after adding these overlays, I can say now that the PR is complete and ready for a review! |
This request is focused on adding to the game a new rock-themed tileset, but has many extra features and tweaks.
New features:
Tweaks:
Todo list: