Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework for Android builds/workflows #2485

Draft
wants to merge 151 commits into
base: master
Choose a base branch
from

Conversation

MatusGuy
Copy link
Member

@MatusGuy MatusGuy commented Jun 4, 2023

This pull request scraps the old android builds that used ndk-build/makefiles for a better and more compatible CMake solution

commits are pretty unorganized

marked as draft because some stuff is yet to be implemented:

  • downloading addons
  • auto locale
  • keyboard
  • tweak funky button hitboxes (optional)
  • opengl es (optional)
  • workflow builds but generates unplayable apk, fix that
  • some workflows stopped working because of this one, fix that
  • fix weird aspect ratios i guess? (tempfix)
  • split workflow into architectures (optional)

@MatusGuy MatusGuy marked this pull request as ready for review August 23, 2023 21:16
- name: Copy precompiled libraries from cache
uses: actions/cache@v2
id: cache
../../../.ci_scripts/clone_dependency.sh libsdl-org/SDL_image release-2.6.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe work with pushd / popd here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the script clones into current directory

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay.

@MatusGuy MatusGuy added status:needs-work In progress, but no one is currently working on it (New volunteers welcome) status:conditional Needs a requirement to be satisfied before merging. and removed status:needs-review Work needs to be reviewed by other people labels Dec 1, 2023
@MatusGuy MatusGuy marked this pull request as draft December 1, 2023 21:35
@MatusGuy
Copy link
Member Author

MatusGuy commented Dec 1, 2023

Depends on #2621

@MatusGuy MatusGuy self-assigned this Jan 9, 2024
@Vankata453 Vankata453 added this to the 0.7.0 milestone May 7, 2024
@MatusGuy MatusGuy removed the status:needs-work In progress, but no one is currently working on it (New volunteers welcome) label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tests os:android status:conditional Needs a requirement to be satisfied before merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants