Support protobuf serializer for custom types#523
Open
tornac1234 wants to merge 7 commits intoSubnauticaModding:masterfrom
Open
Support protobuf serializer for custom types#523tornac1234 wants to merge 7 commits intoSubnauticaModding:masterfrom
tornac1234 wants to merge 7 commits intoSubnauticaModding:masterfrom
Conversation
tornac1234
changed the title
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
Metious
requested changes
Jan 7, 2024
Member
Metious
left a comment
Metious
left a comment
There was a problem hiding this comment.
Overall it looks pretty good. Though I believe we should try to make the serializing callbacks auto-generated since they shouldn't contain any custom code.
This is a very nice implementation. Nicely done
…, and adapted the example accordingly
tornac1234
force-pushed
the
protobuf-serializer-support
branch
from
b56f030 to
0b97c7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made in this pull request
As I don't own BZ, someone else will need to adapt this code for it.