[Bugfix:Autograding] Fix location of Jupyter Dockerfile #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmcutler
requested changes
Sep 8, 2024
There was a problem hiding this comment.
I think instead of jupyter/jupyter, we would like to do jupyter/2.71
and then latestTag would be "2.71".
(but @cjreed121 should confirm)
Correct. I've been discussing this with him off of GitHub. We may consider also tagging the associated python version. |
|
@bmcutler and @cjreed121, the latest commit pins |
bmcutler
pushed a commit
that referenced
this pull request
Sep 9, 2024
### What is the current behavior? #47 changed the value of the "latestTag" metadata attribute, but did not change the directory for the Dockerfile, resulting in the image being tagged `submitty/jupyter:jupyter` instead of `submitty/jupyter:7.2`. ### What is the new behavior? Fixes the directory structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
#40 inadvertently put the Jupyter Dockerfile in the wrong directory.
What is the new behavior?
Fixes the directory structure.