Skip to content

Conversation

@gAmUssA
Copy link

@gAmUssA gAmUssA commented Jan 3, 2016

@FichteFoll please, review

@FichteFoll
Copy link
Member

You should apply the link replacement to all regions (for sel in self.view.sel():) and not just the first one. That aside, views can actually have "no selections" in which case your code would raise an IndexError.

By the way, you could also implement this as a macro (insert_snippet -> paste), but you're less flexible with specifying the new selections that way.

@FichteFoll
Copy link
Member

You should also provide the same commands as key bindings for all OSes and not just OSX.

@gAmUssA
Copy link
Author

gAmUssA commented Jan 6, 2016

@FichteFoll done

@FichteFoll
Copy link
Member

What about the all selections part?

@FichteFoll
Copy link
Member

@gAmUssA, can you address these concerns?

You should apply the link replacement to all regions (for sel in self.view.sel():) and not just the first one. That aside, views can actually have "no selections" in which case your code would raise an IndexError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants