Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Company integration tests #203

Merged
merged 10 commits into from
Nov 29, 2021
Merged

Company integration tests #203

merged 10 commits into from
Nov 29, 2021

Conversation

Ivailo369369
Copy link
Collaborator

#200 Company integration tests & fix all warnings from stylecop!

@Ivailo369369 Ivailo369369 added the back-end back end problem label Nov 29, 2021
@Ivailo369369 Ivailo369369 self-assigned this Nov 29, 2021
@gitguardian
Copy link

gitguardian bot commented Nov 29, 2021

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
Secret Commit Filename Detected At
SendGrid Key d8854ec Tests/UpSkill.Web.Tests/testsettings.json 16:43 November 26th, 2021 View secret
Microsoft Azure Storage Account Key d8854ec Tests/UpSkill.Web.Tests/testsettings.json 16:43 November 26th, 2021 View secret
Generic High Entropy Secret d8854ec Tests/UpSkill.Web.Tests/testsettings.json 16:43 November 26th, 2021 View secret
🛠 How to resolve this
  1. Understand the implications of revoking this secret by examining where it is used in your code.

  2. Replace and store your secret safely. Learn here the best practices

  3. Revoke and rotate this secret

  4. If possible, rewrite your git history to remove all evidence of the secret leak. Please beware this is not a trivial operation. You might completely break other contributing developers’ workflow and you risk accidentally deleting work in progress.

💡 To avoid such incidents in the future, consider following these best practices for managing and storing secrets including API keys and other credentials.

You are seeing this because you or someone else has authorized GitGuardian to scan pull requests

@Ivailo369369 Ivailo369369 merged commit f8e22a3 into development Nov 29, 2021
@Ivailo369369 Ivailo369369 deleted the CompanyIntegrationTests branch November 29, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end back end problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants