Feature/2198/multitool multi select move pages

[reecebrowne]

Description

Drag and drop multiple pages at once using checkboxes

Closes #(2198)

Checklist

• [ X] I have read the Contribution Guidelines
• [ X] I have performed a self-review of my own code
• [ X] I have attached images of the change if it is UI based
• [ X] I have commented my code, particularly in hard-to-understand areas
• [ X] If my code has heavily changed functionality I have updated relevant docs on Stirling-PDFs doc repo
• [ X] My changes generate no new warnings
• [ X] I have read the section Add New Translation Tags (for new translation tags only)

[github-actions]

🚀 Translation Verification Summary

📋 Checking with the file messages_en_GB.properties from the pr-branch - Checking the pr-branch

🗂️ Checking File: messages_ar_AR.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_bg_BG.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_ca_CA.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_cs_CZ.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_da_DK.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_de_DE.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_el_GR.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_en_US.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_es_ES.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_eu_ES.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_fr_FR.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_ga_IE.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_hi_IN.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_hr_HR.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_hu_HU.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_id_ID.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_it_IT.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_ja_JP.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_ko_KR.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_nl_NL.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_no_NB.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_pl_PL.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_pt_BR.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_pt_PT.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_ro_RO.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_ru_RU.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_sk_SK.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_sr_LATN_RS.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_sv_SE.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_th_TH.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_tr_TR.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_uk_UA.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_vi_VN.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_zh_CN.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

🗂️ Checking File: messages_zh_TW.properties...

• Test 1 Status: ✅ Passed
• Test 2 Status: ✅ Passed

---

✅ Overall Check Status: Success

Thanks @reecebrowne for your help in keeping the translations up to date.

[Frooodle]

/deploypr

[github-actions]

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:2294

This deployment will be automatically cleaned up when the PR is closed.

[Frooodle]

one weird interaction
select page(s) with multi select, drag them, then clears the select page menu (I understand why you want it to clear)
since its cleared its means you have basically disabled all top buttons even if the user wants to do a rotate all

I think with the usecase of user clicking when selected pages = 0 we have it act as though its not in select mode at all?

[Frooodle]

Also do you think its valuable to implement a multi select -direction shift- as well?
Honest question for opinion just typing it before I forget

if you have 2,5,9 selected and you go on one of them and hit the move right one space key should it shift them all one space?
Right now this multiselect it good for grouping pages but not mass shifting them etc

[reecebrowne]

one weird interaction
select page(s) with multi select, drag them, then clears the select page menu (I understand why you want it to clear)
since its cleared its means you have basically disabled all top buttons even if the user wants to do a rotate all

I think with the usecase of user clicking when selected pages = 0 we have it act as though its not in select mode at all?

Agreed that maybe it is a little weird, I think dropping right out of select mode is also a little wonky though. Perhaps retaining now moved pages as checked pages? I wasn't sure either way

Also do you think its valuable to implement a multi select -direction shift- as well? Honest question for opinion just typing it before I forget

if you have 2,5,9 selected and you go on one of them and hit the move right one space key should it shift them all one space? Right now this multiselect it good for grouping pages but not mass shifting them etc

Yes 100% agree that other methods would be good and possibly outright better than the drag and drop, I have some ideas for what to do here but decided to make it a 2nd phase so that this initial feature can go out for now.

[Frooodle]

one weird interaction
select page(s) with multi select, drag them, then clears the select page menu (I understand why you want it to clear)
since its cleared its means you have basically disabled all top buttons even if the user wants to do a rotate all
I think with the usecase of user clicking when selected pages = 0 we have it act as though its not in select mode at all?

Agreed that maybe it is a little weird, I think dropping right out of select mode is also a little wonky though. Perhaps retaining now moved pages as checked pages? I wasn't sure either way

Also do you think its valuable to implement a multi select -direction shift- as well? Honest question for opinion just typing it before I forget
if you have 2,5,9 selected and you go on one of them and hit the move right one space key should it shift them all one space? Right now this multiselect it good for grouping pages but not mass shifting them etc

Yes 100% agree that other methods would be good and possibly outright better than the drag and drop, I have some ideas for what to do here but decided to make it a 2nd phase so that this initial feature can go out for now.

It would break you away if it removed the 'mode' UI but a user shouldn't click the rotate button and it do nothing
if there is no selected pages for it to rotate since its empty you should assume the user wants to rotate all pages (but can keep selection UI open I guess?)

[reecebrowne]

one weird interaction
select page(s) with multi select, drag them, then clears the select page menu (I understand why you want it to clear)
since its cleared its means you have basically disabled all top buttons even if the user wants to do a rotate all
I think with the usecase of user clicking when selected pages = 0 we have it act as though its not in select mode at all?

Agreed that maybe it is a little weird, I think dropping right out of select mode is also a little wonky though. Perhaps retaining now moved pages as checked pages? I wasn't sure either way

Also do you think its valuable to implement a multi select -direction shift- as well? Honest question for opinion just typing it before I forget
if you have 2,5,9 selected and you go on one of them and hit the move right one space key should it shift them all one space? Right now this multiselect it good for grouping pages but not mass shifting them etc

Yes 100% agree that other methods would be good and possibly outright better than the drag and drop, I have some ideas for what to do here but decided to make it a 2nd phase so that this initial feature can go out for now.

It would break you away if it removed the 'mode' UI but a user shouldn't click the rotate button and it do nothing if there is no selected pages for it to rotate since its empty you should assume the user wants to rotate all pages (but can keep selection UI open I guess?)

Would definitely have to turn off the mode and have them have to re-enter it, Download selected needs to disappear and page break needs to be clear it's going to apply to every page, especially as right now there is no undo for that beyond manually deleting pages.