Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

welcome to pdf #2202

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

welcome to pdf #2202

wants to merge 4 commits into from

Conversation

linhexu
Copy link

@linhexu linhexu commented Nov 9, 2024

Description

This pull request introduces a welcome message on the first-time execution of the Stirling-PDF application, providing users with an explanation of what local hosting is and its benefits. The motivation behind this change is to enhance the onboarding experience for new users, ensuring they understand the context of using a locally hosted application. This feature is particularly useful for users who may not be familiar with the concept of local hosting and how it differs from cloud-based solutions.

Closes #2110

Checklist

  • [✓] I have read the Contribution Guidelines
  • [✓] I have performed a self-review of my own code
  • [✓] I have attached images of the change if it is UI based (Not applicable in this case as the change is not UI-based)
  • [✓] I have commented my code, particularly in hard-to-understand areas
  • [✓] My changes generate no new warnings
  • [✓] I have read the section Add New Translation Tags (Not applicable in this case as no new translation tags were added)

Additional Notes

I have added a welcome message to the home.html file, which is displayed when the application is first executed. The message explains the concept of local hosting and its advantages. I have also created a separate CSS file welcome-message.css to style the welcome message appropriately. No new warnings were generated after integrating these changes, and the code has been thoroughly commented to ensure ease of understanding.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Nov 9, 2024
@github-actions github-actions bot added the Front End Issues or pull requests related to front-end development label Nov 9, 2024
</head>

<body>
<div id="welcome-message" class="welcome-message">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use static text
All text must use translation tags

</head>

<body>
<div id="welcome-message" class="welcome-message">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably only want to show this for the exe version
Anyone running docker should know what self hosting is

</head>

<body>
<div id="welcome-message" class="welcome-message">
<h1>Welcome to Stirling PDF!</h1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want this as a popup or your current implementation

Any UI changes need screenshots attached so we can see your change

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Front End Issues or pull requests related to front-end development needs-changes size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add welcome message explaining what local hosting is etc for first time exe openings
2 participants