-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
welcome to pdf #2202
base: main
Are you sure you want to change the base?
welcome to pdf #2202
Conversation
</head> | ||
|
||
<body> | ||
<div id="welcome-message" class="welcome-message"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't use static text
All text must use translation tags
</head> | ||
|
||
<body> | ||
<div id="welcome-message" class="welcome-message"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably only want to show this for the exe version
Anyone running docker should know what self hosting is
</head> | ||
|
||
<body> | ||
<div id="welcome-message" class="welcome-message"> | ||
<h1>Welcome to Stirling PDF!</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we want this as a popup or your current implementation
Any UI changes need screenshots attached so we can see your change
Description
This pull request introduces a welcome message on the first-time execution of the Stirling-PDF application, providing users with an explanation of what local hosting is and its benefits. The motivation behind this change is to enhance the onboarding experience for new users, ensuring they understand the context of using a locally hosted application. This feature is particularly useful for users who may not be familiar with the concept of local hosting and how it differs from cloud-based solutions.
Closes #2110
Checklist
Additional Notes
I have added a welcome message to the
home.html
file, which is displayed when the application is first executed. The message explains the concept of local hosting and its advantages. I have also created a separate CSS filewelcome-message.css
to style the welcome message appropriately. No new warnings were generated after integrating these changes, and the code has been thoroughly commented to ensure ease of understanding.