Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Friendly Merge File Selction #1548

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

t71rs
Copy link
Contributor

@t71rs t71rs commented Jul 9, 2024

Regarding reverted PR #1204

This PR implements the same changes as the one mentioned above. But it distinguishes file input forms by using the multiple variable of the form. As of right now merge is the only page where these changes are useful in my opinion. If in the future a feature is implemented where these changes are useful, they can be used by setting multiple to true in the Form. At this moment the pipeline page is the only other page where multiple is set to true, but since these changes would not be user friendly for the pipeline page I made sure it is not affected.
Also I made sure that the Duplicate warning is dynamic and translatable this time.

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

@t71rs t71rs requested a review from Frooodle as a code owner July 9, 2024 12:50
@github-actions github-actions bot added Front End Issues or pull requests related to front-end development Translation labels Jul 9, 2024
@Frooodle
Copy link
Member

Frooodle commented Aug 3, 2024

Sorry for taking so long to look at these, its awkward to find time recently to download someone else's repo and build image etc to test before merge
need to setup github workspaces :D

@Frooodle
Copy link
Member

Frooodle commented Aug 6, 2024

Just been testing this, i think we need to add a clear all/ delete all button, the only away to restart is to refresh the whole page which I think many won't do/ bad UX. what do you think?
Duplicate warning didn't work for me but I think that's fine regardless,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Front End Issues or pull requests related to front-end development needs-changes Translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants