-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve NavigationBar and related tests #76
Open
ahuston-0
wants to merge
16
commits into
main
Choose a base branch
from
reichenbach-navbar-testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuston-0
commented
May 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just gotta see what Prof. Kruger thinks of the changes.
Fix test/CMakeLists.txt structure. The main branch has switched over to using a tree of CMakeLists to clean the structure up a bit. Also readded test2Tabs to the new system. Signed-off-by: ahuston-0 <[email protected]>
All currently compiling tests have been switched over to the new grailmain. Also, apparently test/xp/CMakeLists.txt was never added to the previous commit. Signed-off-by: ahuston-0 <[email protected]>
Currently this throws an exception if a tab doesn't exist. My hope is that the branch predictor will notice that the condition is true most of the time and just return most of the time. Signed-off-by: ahuston-0 <[email protected]>
Copies over .gitattributes from main repo to ensure that files are handled properly. Fixes several tests dependent on GraphWidget and ButtonWidget to ensure that the demos are kept in working condition (and the CI is not spitting out errors every time a push is made) Signed-off-by: ahuston-0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.