Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ECS-Style Input System #43

Closed
wants to merge 14 commits into from
Closed

Merge ECS-Style Input System #43

wants to merge 14 commits into from

Conversation

dkrautha
Copy link
Collaborator

No description provided.

@dkrautha dkrautha changed the title Better input Merge ECS-Style Input System Jul 19, 2021
@ahuston-0
Copy link
Collaborator

ahuston-0 commented Aug 19, 2021

Linked #16 and #28 to this as they both seem relevant to the situation. Also, just as a heads up, the tabbed-windows branch is currently experimenting with a CallbackHandler class that the callback managers can inherit from. I know that currently the GLWin handles callbacks, and as such that is what this is updating, but an inherited CallbackHandler allows us to allow the Tab to handle callbacks if we need to (such as in the tabbed-windows branch). Also, if this code got merged in as another instance of a CallbackHandler (or similar class implementation), then we can modularly swap out different callback handler methods as we see fit.

I'd like to see this code tested with rest of the codebase sooner rather than later, we just need to get it merged.

Let me know if I can be any help with getting this merged/testing/reviewing.

@dkrautha
Copy link
Collaborator Author

It's been years and it seems like some other system was implemented for keyboard input, so I'm closing this so that we don't have to keep looking at it.

@dkrautha dkrautha closed this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants