-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge ECS-Style Input System #43
Conversation
Also modifies the for : each loop in GLWin's key callback function to theoretically call handleInputs in a parallelized way
I have no idea why this happened, I have to assume that MPV just didn't like the string it was being given. It works now though.
Linked #16 and #28 to this as they both seem relevant to the situation. Also, just as a heads up, the tabbed-windows branch is currently experimenting with a CallbackHandler class that the callback managers can inherit from. I know that currently the GLWin handles callbacks, and as such that is what this is updating, but an inherited CallbackHandler allows us to allow the Tab to handle callbacks if we need to (such as in the tabbed-windows branch). Also, if this code got merged in as another instance of a CallbackHandler (or similar class implementation), then we can modularly swap out different callback handler methods as we see fit. I'd like to see this code tested with rest of the codebase sooner rather than later, we just need to get it merged. Let me know if I can be any help with getting this merged/testing/reviewing. |
It's been years and it seems like some other system was implemented for keyboard input, so I'm closing this so that we don't have to keep looking at it. |
No description provided.