This repository has been archived by the owner on Jun 5, 2023. It is now read-only.
Implemented Dispose #18
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's |
|
@ajmcateer Thanks for contributing this! Do you think you'll be in a position to finish this PR off? That would involve figuring out the solution to whatever issue you're describing, as well as tidy this up to remove the unnecessary changes (e.g., in If that's not something you'll get round to, no problem - I may add some functionality like this myself eventually, though there's no ETA. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented dispose in the WebWindow but I am having trouble getting it to work in Windows.
Linux was a complete shot in the dark as I have never worked with C++ let alone on Linux before.
I get
Exception thrown: 'System.EntryPointNotFoundException' in WebWindow.dllwhenever I try to call the dispose method. As far as I can tell I implemented everything correctly, but I am knew to C++ so its very likely I missed something. Any feedback would be greatly appreciated. I also didn't see a WebWindow.Mac.cpp file to make changes too.