Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noetic-devel Fix Dockerfile #721

Draft
wants to merge 1 commit into
base: noetic-devel
Choose a base branch
from

Conversation

pawelg89
Copy link

@pawelg89 pawelg89 commented Jul 23, 2024


Basic Info

Info Please fill out this column
Ticket(s) this addresses didn't see any, just trying out locally
Primary OS tested on Ubuntu
Robotic platform tested on (gazebo simulation)

Description of contribution in a few bullet points

Fixes:

  • Dockerfile looked like copy paste from melodic
  • changed image to noetic-ros-base-focal
  • added install of git to container
  • switched to python3-catkin-tools from python-catkin-tools

Description of documentation updates required from your changes


Future work that may be required in bullet points

Fixes:
* Dockerfile looked like copy paste from melodic
* changed image to noetic-ros-base-focal
* added install of git to container
* switched to python3-catkin-tools from python-catkin-tools
Copy link
Owner

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still draft?

@pawelg89 pawelg89 marked this pull request as ready for review August 5, 2024 11:19
@pawelg89 pawelg89 marked this pull request as draft August 5, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants