Map saving and serialization services return bool #546
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update slam_toolbox_common.cpp Update DeserializePoseGraph.srv Update SaveMap.srv Update SerializePoseGraph.srv Update serialization.hpp Update serialization.hpp
|
This would only be possible in ROS 2, ROS 1 APIs have been set and are released. Is this something you're willing to forward port to ROS 2 and meet your needs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
### Note: This PR is for reference only mostly, as it breaks API.
| Primary OS tested on | Ubuntu |
| Robotic platform tested on | Locus Vector |
Description
The services to save and serialize a map can be called externally, and it is useful
to know whether they succeeded. The current empty service calls just hope for
the best, but this PR includes modifications to return the actual outcome.
Description of documentation updates required from your changes
If merged, this PR would probably need an update to the Readme
Future work
These changes may be worth considering for future versions in new distros