-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lambert W x F distributions to XGBoostLSS #65
base: master
Are you sure you want to change the base?
Conversation
@gmgeorg Thanks for creating the PR. I assume you further refine the notebooks and the .py files? Since, e.g., the Gaussian example still has some explanations for modelling the gaussian distribution whereas it should explain the Lambert W x F distributions. Also, result wise, the gaussian example notebook does not look good. |
@StatMixedML yes will clean up. However, I wanted to send this out first as a general "it works" proof of concept PR. If this looks good to you high level with the current changes, I will continue and Let me know if I should revisit/re-implement differently any proposed changes; if not, will go ahead and clean up rest of PR for a e2e review. |
…tw-distributions; update notebooks
@StatMixedML updated PR with changes addressing earlier points. PTAL |
@gmgeorg, would you be interested adding some distributions to See proposed integration issue here: sktime/skpro#184 Integration with |
@fkiraly Great idea! Will take a look and add an issue there. |
Adds skewed and tail Lambert W x F distributions as an option to XGBoostLSS.
In particular, adds Lambert W x {Normal, Weibull, Gamma, Exponential, LogNormal} distributions. Adds examples to notebooks and adds its own California Housing example notebook.