Concurrent Incidents

[bliitzkrieg]

Overview

Added ability to toggle concurrent incidents on map inside Incident analysis view

GitHub Issues

• Show concurrent incidents on Incident Analysis Page #481

Changes

• N/A

Screenshots / Videos

Steps to Test

• Find incident in incident analysis with concurrent incidents
• Scroll to Map
• Click Layer button to toggle them on
• Search around map to find concurrent incidents

[bliitzkrieg]

@chopchop505 Should be good for review. Do you want to use a different icon for the toggle?

[larskendall]

Looks great to me overall. I just added some notes for one bug I noticed, along with a couple other minor suggestions.

One other useful addition would be to have an "enabled" visual state for the button, so that you can tell when concurrent incidents are being displayed or not. Right now it's ambiguous. You could try giving it a border value of 2px solid #00a7dc when it's enabled, which should look pretty good I think. For that to work well you'd probably also need to set outline: none in the button's focus state. Otherwise it'll always look like it's enabled when you click it.

[larskendall]

I noticed one more thing that should probably be adjusted...

Right now there's some default styling for the incident map component that's mixed in the incident analysis page's css (.incident-map-container and .incident-map-concurrent-layer in incident-analysis.scss), but I think that probably belongs in a file specifically for the incident map component, so that it's reusable. Otherwise you'd have to set the styling for that stuff again for any page where you want to reuse the concurrent incidents toggle button.

[bliitzkrieg]

Should be good for review

[larskendall]

Looks great! I'll merge it in.