Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequelize Upgrade #470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sequelize Upgrade #470

wants to merge 1 commit into from

Conversation

bliitzkrieg
Copy link
Contributor

Overview

Upgraded sequelize to version 4.12

GitHub Issues

Changes

  • Removed instance methods
  • Moved instance methods to prototype

Screenshots / Videos

N/A

Steps to Test

  • Go through application and make sure no server or client errors

@bliitzkrieg bliitzkrieg requested a review from chopchop505 May 20, 2020 01:18
@bliitzkrieg bliitzkrieg self-assigned this May 20, 2020
@bliitzkrieg
Copy link
Contributor Author

This needs manual testing. I've done a smoketest and everything appears to be working. Could you give it your own smoketest and maybe dive into parts of the app that aren't obvious

@bliitzkrieg
Copy link
Contributor Author

Screen Shot 2020-05-19 at 9 19 58 PM

I couldn't find any instances of the application using a belongsToMany relationship like this but let me know if you know of any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant