Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support sampling statistics collection for external table #52608

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Youngwb
Copy link
Contributor

@Youngwb Youngwb commented Nov 5, 2024

Why I'm doing:

What I'm doing:

  1. support analyze sample tbl xx for external table
  2. support create analyze sample tbl for external table
  3. support query tigger analyze with partition sample

This sampling method only performs sampling at the partition level and does not sample within the partitions.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: Youngwb <[email protected]>
Copy link

sonarcloud bot commented Nov 5, 2024

Copy link

github-actions bot commented Nov 6, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 6, 2024

[FE Incremental Coverage Report]

pass : 174 / 189 (92.06%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/statistics/StatisticsUtils.java 10 18 55.56% [87, 92, 101, 102, 104, 105, 107, 108]
🔵 com/starrocks/statistic/ColumnStatsMeta.java 10 11 90.91% [86]
🔵 com/starrocks/statistic/StatisticsCollectJobFactory.java 57 62 91.94% [146, 225, 260, 262, 263]
🔵 com/starrocks/statistic/StatisticUtils.java 53 54 98.15% [575]
🔵 com/starrocks/connector/statistics/ConnectorAnalyzeTask.java 21 21 100.00% []
🔵 com/starrocks/connector/hive/HiveStatisticsProvider.java 1 1 100.00% []
🔵 com/starrocks/server/MetadataMgr.java 3 3 100.00% []
🔵 com/starrocks/statistic/ExternalBasicStatsMeta.java 1 1 100.00% []
🔵 com/starrocks/common/Config.java 1 1 100.00% []
🔵 com/starrocks/statistic/StatisticExecutor.java 10 10 100.00% []
🔵 com/starrocks/sql/optimizer/statistics/CachedStatisticStorage.java 1 1 100.00% []
🔵 com/starrocks/statistic/ExternalSampleStatisticsCollectJob.java 6 6 100.00% []

Copy link

github-actions bot commented Nov 6, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants